> On May 24, 2018, 4:15 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/libprocess/src/tests/jwt_tests.cpp > > Line 26 (original) > > <https://reviews.apache.org/r/67285/diff/1/?file=2028323#file2028323line26> > > > > I think this file is also listed in a Makefile somewhere and that > > should get deleted...
No, it's not listed. ``` [jpeach@jpeach asf-mesos]$ git grep jwt_keys.hpp [jpeach@jpeach asf-mesos]$ ``` - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67285/#review203776 ----------------------------------------------------------- On May 24, 2018, 3:48 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67285/ > ----------------------------------------------------------- > > (Updated May 24, 2018, 3:48 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > The JWT test keys were only used by the JWT tests, so there was > no necessity for them to be in a header file. Moved them into the > source file to fix `make distcheck` which was failing because the > `jwt_keys.hpp` header wasn't included in the distribution. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/jwt_keys.hpp > 0fb9a989da4d0ff2eaf6b304922ae68206319079 > 3rdparty/libprocess/src/tests/jwt_tests.cpp > 581438d7b8811474d694e9482dfffe8b5068e53f > > > Diff: https://reviews.apache.org/r/67285/diff/1/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
