----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/#review203791 -----------------------------------------------------------
Fix it, then Ship it! usually we start the commit msg with a transformed verb. (e.g., `Changed`). here I would sugggest something like `Renamed an ambiguous variable in network port isolator.`, which may be more intuitive. src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 532-533 (patched) <https://reviews.apache.org/r/67271/#comment286089> fit in oneline? - Gilbert Song On May 23, 2018, 11:42 a.m., Xudong Ni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67271/ > ----------------------------------------------------------- > > (Updated May 23, 2018, 11:42 a.m.) > > > Review request for mesos and James Peach. > > > Bugs: MESOS-8340 > https://issues.apache.org/jira/browse/MESOS-8340 > > > Repository: mesos > > > Description > ------- > > Change ambiguous parameter name. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.hpp > ba71087194a3ae74c7e40dffa9c108b02ffa10ad > src/slave/containerizer/mesos/isolators/network/ports.cpp > 1f84ed4fb2a30fd095e2faec1038de1fa19a15c5 > > > Diff: https://reviews.apache.org/r/67271/diff/2/ > > > Testing > ------- > > > Thanks, > > Xudong Ni > >
