----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67298/ -----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Repository: mesos Description ------- It turns out that even with C++11, some `std::list::size()` implementations are still linear in complexity. This was found when running perf against a metrics benchmark for the master. A follow-up to avoid std::list in the collect.hpp interfaces entirely is needed. Diffs ----- 3rdparty/libprocess/include/process/collect.hpp 7e07b1db8fdb577daa58e83a1295e2d9845ffc31 Diff: https://reviews.apache.org/r/67298/diff/1/ Testing ------- Before: ``` Registered 2000 frameworks Finished launching the tasks; Sleep 10 seconds ... Start collecting metrics ... v0 '/metrics/snapshot' response took 17.751689014secs v1 'master::call::GetMetrics' application/x-protobuf response took 17.523928635secs v1 'master::call::GetMetrics' application/json response took 18.111901732secs ``` After: ``` Registered 2000 frameworks Finished launching the tasks; Sleep 10 seconds ... Start collecting metrics ... v0 '/metrics/snapshot' response took 1.730948431secs v1 'master::call::GetMetrics' application/x-protobuf response took 1.697177667secs v1 'master::call::GetMetrics' application/json response took 2.160314525secs ``` Thanks, Benjamin Mahler
