> On May 18, 2018, 8:53 p.m., Chun-Hung Hsiao wrote:
> > Haven't take a good at these but they might be candidates to use the new
> > macros:
> > ```
> > $ grep '(EXPECT\|ASSERT)_(TRUE\|FALSE)(.*is(Some\|Error\|None)())'
> > 3rdparty/stout/ -r
> > ...
> > 3rdparty/stout//tests/ip_tests.cpp: EXPECT_FALSE(network.isError());
> > 3rdparty/stout//tests/mac_tests.cpp: EXPECT_FALSE(mac.isError());
> > 3rdparty/stout//tests/none_tests.cpp: EXPECT_TRUE(o.isNone());
> > 3rdparty/stout//tests/none_tests.cpp: EXPECT_TRUE(o.isNone());
> > 3rdparty/stout//tests/none_tests.cpp: EXPECT_TRUE(o.isNone());
> > 3rdparty/stout//tests/none_tests.cpp: EXPECT_TRUE(r.isNone());
> > 3rdparty/stout//tests/none_tests.cpp: EXPECT_TRUE(r.isNone());
> > 3rdparty/stout//tests/none_tests.cpp: EXPECT_TRUE(r.isNone());
> > 3rdparty/stout//tests/os_tests.cpp: ASSERT_FALSE(process.isError());
> > 3rdparty/stout//tests/os_tests.cpp: ASSERT_FALSE(process.isError());
> > ```
> > We could fix them in a follow-up patch.
I have updated this patch to fix some of these as well. Note in general the fix
here does not apply to some checks we perform on `Result` values of the form
(EXPECT\|ASSERT)_TRUE(.*isError)
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67210/#review203442
-----------------------------------------------------------
On May 29, 2018, 10:13 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67210/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 10:13 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `*_SOME` macro for checking `Try` values in stout.
>
>
> Diffs
> -----
>
> 3rdparty/stout/tests/none_tests.cpp
> b6bbb882ca2d61db9d93870895bc076612f26f84
> 3rdparty/stout/tests/os/sendfile_tests.cpp
> 2a8568365c88ee7207c38f74599dcd3ba0f73410
>
>
> Diff: https://reviews.apache.org/r/67210/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
