----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67362/#review204011 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On May 29, 2018, 8:20 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67362/ > ----------------------------------------------------------- > > (Updated May 29, 2018, 8:20 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Bugs: MESOS-8958 > https://issues.apache.org/jira/browse/MESOS-8958 > > > Repository: mesos > > > Description > ------- > > The `linux/devices` isolator tests fail to build on on > Ubuntu 14.04 with `gcc (Ubuntu 4.8.4-2ubuntu1~14.04.4) > 4.8.4` due to what seems to me a compiler bug, possibly > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57824. > > Work around any compiler issues by defining the test cases > in a separate vector so that the copmiler doesn't have any > raw strings in the macro expansion. > > > Diffs > ----- > > src/tests/containerizer/linux_devices_isolator_tests.cpp > efaa43b8b7b7c73c35d995bfbb81fcd620143ea1 > > > Diff: https://reviews.apache.org/r/67362/diff/2/ > > > Testing > ------- > > sudo make check (Fedora 27) > > > Thanks, > > James Peach > >
