----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/#review204043 -----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['67274']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274/logs/mesos-tests-stdout.log): ``` [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (108 ms) [----------] 9 tests from Endpoint/SlaveEndpointTest (1022 ms total) [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (33 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 ms) [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms total) [----------] 1 test from IsolationFlag/CpuIsolatorTest [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (674 ms) [----------] 1 test from IsolationFlag/CpuIsolatorTest (698 ms total) [----------] 1 test from IsolationFlag/MemoryIsolatorTest [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (737 ms) [----------] 1 test from IsolationFlag/MemoryIsolatorTest (762 ms total) [----------] Global test environment tear-down [==========] 981 tests from 95 test cases ran. (443701 ms total) [ PASSED ] 980 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.SigkillExecutor/0, where GetParam() = "docker,mesos" 1 FAILED TEST YOU HAVE 220 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274/logs/mesos-tests-stderr.log): ``` I0530 11:52:00.663715 6448 master.cpp:10843] Updating the state of task 0d513779-8e11-40f4-a465-34ed26bb379c of framework 391f9f39-db6c-4df1-a6a0-f45980daade0-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED) I0530 11:52:00.663715 18696 slave.cpp:3935] Shutting down framework 391f9f39-db6c-4df1-a6a0-f45980daade0-0000 I0530 11:52:00.663715 18696 slave.cpp:6656] Shutting down executor '0d513779-8e11-40f4-a465-34ed26bb379c' of framework 391f9f39-db6c-4df1-a6a0-f45980daade0-0000 at executor(1)@192.10.1.6:5I0530 11:52:00.512697 16056 exec.cpp:162] Version: 1.7.0 I0530 11:52:00.536702 3188 exec.cpp:236] Executor registered on agent 391f9f39-db6c-4df1-a6a0-f45980daade0-S0 I0530 11:52:00.540697 21196 executor.cpp:178] Received SUBSCRIBED event I0530 11:52:00.544697 21196 executor.cpp:182] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net I0530 11:52:00.544697 21196 executor.cpp:178] Received LAUNCH event I0530 11:52:00.549700 21196 executor.cpp:665] Starting task 0d513779-8e11-40f4-a465-34ed26bb379c I0530 11:52:00.627722 21196 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>' I0530 11:52:00.639719 21196 executor.cpp:678] Forked command at 19200 I0530 11:52:00.665704 19324 exec.cpp:445] Executor asked to shutdown I0530 11:52:00.666703 17180 executor.cpp:178] Received SHUTDOWN event I0530 11:52:00.666703 17180 executor.cpp:781] Shutting down I0530 11:52:00.666703 17180 executor.cpp:894] Sending SIGTERM to process tree at pid 193574 I0530 11:52:00.665704 6448 master.cpp:10942] Removing task 0d513779-8e11-40f4-a465-34ed26bb379c with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 391f9f39-db6c-4df1-a6a0-f45980daade0-0000 on agent 391f9f39-db6c-4df1-a6a0-f45980daade0-S0 at slave(447)@192.10.1.6:53553 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) I0530 11:52:00.666703 18696 slave.cpp:929] Agent terminating W0530 11:52:00.666703 18696 slave.cpp:3931] Ignoring shutdown framework 391f9f39-db6c-4df1-a6a0-f45980daade0-0000 because it is terminating I0530 11:52:00.668705 6448 master.cpp:1293] Agent 391f9f39-db6c-4df1-a6a0-f45980daade0-S0 at slave(447)@192.10.1.6:53553 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected I0530 11:52:00.668705 6448 master.cpp:3303] Disconnecting agent 391f9f39-db6c-4df1-a6a0-f45980daade0-S0 at slave(447)@192.10.1.6:53553 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) I0530 11:52:00.668705 6448 master.cpp:3322] Deactivating agent 391f9f39-db6c-4df1-a6a0-f45980daade0-S0 at slave(447)@192.10.1.6:53553 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) I0530 11:52:00.669704 18608 hierarchical.cpp:344] Removed framework 391f9f39-db6c-4df1-a6a0-f45980daade0-0000 I0530 11:52:00.670701 18608 hierarchical.cpp:766] Agent 391f9f39-db6c-4df1-a6a0-f45980daade0-S0 deactivated I0530 11:52:00.670701 1972 containerizer.cpp:2406] Destroying container 6680defa-3869-4d00-bbac-9a2d04e472e1 in RUNNING state I0530 11:52:00.670701 1972 containerizer.cpp:3020] Transitioning the state of container 6680defa-3869-4d00-bbac-9a2d04e472e1 from RUNNING to DESTROYING I0530 11:52:00.670701 1972 launcher.cpp:156] Asked to destroy container 6680defa-3869-4d00-bbac-9a2d04e472e1 I0530 11:52:00.768220 17344 containerizer.cpp:2859] Container 6680defa-3869-4d00-bbac-9a2d04e472e1 has exited I0530 11:52:00.798221 20424 master.cpp:1135] Master terminating I0530 11:52:00.800220 18020 hierarchical.cpp:609] Removed agent 391f9f39-db6c-4df1-a6a0-f45980daade0-S0 I0530 11:52:01.189404 11476 process.cpp:940] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On May 28, 2018, 3:11 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67274/ > ----------------------------------------------------------- > > (Updated May 28, 2018, 3:11 p.m.) > > > Review request for mesos, Jie Yu, Joris Van Remoortere, Michael Park, and > Neil Conway. > > > Bugs: MESOS-8945 > https://issues.apache.org/jira/browse/MESOS-8945 > > > Repository: mesos > > > Description > ------- > > Internally values of scalar resources are stored in a fixed point > representation. This can lead to (expected) precision loss. > > This patch adds resource validation ensuring that values of scalar > resources are either zero or large enough so that they are still > represented as non-zero values after conversion to the internal fixed > point format. > > While this patch should not change valid, intended use cases, it might > change the behavior for erroneous, already broken framework workflows. > > > Diffs > ----- > > src/common/resources.cpp 192d086e60b81c0ae8e26d4120beee2034f63d3e > src/tests/resources_tests.cpp 1201efec3ff0abc268f896c1fe2330571390b3fd > > > Diff: https://reviews.apache.org/r/67274/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
