> On May 30, 2018, 7:48 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/libprocess/include/process/future.hpp > > Line 994 (original), 994 (patched) > > <https://reviews.apache.org/r/67309/diff/1/?file=2029161#file2029161line994> > > > > This patch seems to affect `process::discard` instead of > > `Future::select`. Is there a mistake in the summary?
Ah yes, I ended up not using select anyway, but I'll update the review description since the change to discard is still useful. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67309/#review204066 ----------------------------------------------------------- On May 25, 2018, 2:56 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67309/ > ----------------------------------------------------------- > > (Updated May 25, 2018, 2:56 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Gilbert Song. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > b8508c5018d71885ecb7d239d72c51d8af2dfc19 > > > Diff: https://reviews.apache.org/r/67309/diff/1/ > > > Testing > ------- > > > Thanks, > > Benjamin Mahler > >
