> On May 31, 2018, 4:41 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Line 9459 (original), 9459 (patched) > > <https://reviews.apache.org/r/67403/diff/1/?file=2033322#file2033322line9459> > > > > not yours, but can you log framework id here too?
s/framework id/*framework/ > On May 31, 2018, 4:41 p.m., Vinod Kone wrote: > > src/master/master.cpp > > Lines 9470 (patched) > > <https://reviews.apache.org/r/67403/diff/1/?file=2033322#file2033322line9470> > > > > log framework id? s/framework id/*framework/ - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67403/#review204121 ----------------------------------------------------------- On May 31, 2018, 4:32 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67403/ > ----------------------------------------------------------- > > (Updated May 31, 2018, 4:32 p.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Bugs: MESOS-7966 > https://issues.apache.org/jira/browse/MESOS-7966 > > > Repository: mesos > > > Description > ------- > > When executing the `Master::inverseOffers()` callback, it > could happen that the maintenance window the reverse offer > referred to was already removed by a concurrent call to > to the maintenance endpoint of Mesos. > > In this case, we must not send out a reverse offer, because > having outstanding inverse offers for an agent without > any scheduled maintenance window will lead to a crash in > the allocator when attempting to remove this offer. > > > Diffs > ----- > > src/master/master.cpp ba3f8746ea393c8655fcd5ceaace099f68df0b19 > > > Diff: https://reviews.apache.org/r/67403/diff/1/ > > > Testing > ------- > > `make check` > > Set up the reproduction environment locally and ran `while :; python call.py; > done` for about a minute. (see linked ticket) > > > Thanks, > > Benno Evers > >
