----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67354/#review204131 -----------------------------------------------------------
Looks good to me! Just one comment about logging flags. src/exec/exec.cpp Lines 643-646 (original), 652-655 (patched) <https://reviews.apache.org/r/67354/#comment286521> We don't change executor logging flags in our tests, do we? It might be worth calling out in a comment that this constructor still loads those flags from environment variables. - Ilya Pronin On May 29, 2018, 7:20 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67354/ > ----------------------------------------------------------- > > (Updated May 29, 2018, 7:20 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent > huang, Ilya Pronin, and James Peach. > > > Bugs: MESOS-3475 > https://issues.apache.org/jira/browse/MESOS-3475 > > > Repository: mesos > > > Description > ------- > > This patch adds overloaded constructor for `MesosExecutorDriver` that > accepts `environment` parameter and stores it in the class variable. > This new constructor is needed to get rid of `os::getenv()` calls, > so that `MesosExecutorDriver` can be used in tests that require > thread safety. > > > Diffs > ----- > > include/mesos/executor.hpp d14c0369f6731100d27092142b56f108f8881003 > src/exec/exec.cpp 65a671d7ce83a51087d290ba039d18deba6313c2 > > > Diff: https://reviews.apache.org/r/67354/diff/1/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
