----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67375/#review204135 -----------------------------------------------------------
Ship it! src/csi/rpc.cpp Lines 31 (patched) <https://reviews.apache.org/r/67375/#comment286524> nits: I suggest we align the statements here using the same way: ``` return stream << Identity::service_full_name() << ".GetPluginInfo"; ``` - Jie Yu On May 30, 2018, 2:57 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67375/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 2:57 a.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8943 > https://issues.apache.org/jira/browse/MESOS-8943 > > > Repository: mesos > > > Description > ------- > > To make it easy to enumerate all types of CSI RPC calls, the `RPC` enum > is introduced. The `RPCTraits` helper class can be used to determine the > request and response type of a particular RPC. > > > Diffs > ----- > > src/CMakeLists.txt f86884de2beb946c8bfc2bb8260e09a9c98ce625 > src/Makefile.am b7184ceccef5f2e985d905c155156f95c7a7c7b4 > src/csi/rpc.hpp PRE-CREATION > src/csi/rpc.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/67375/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
