----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67393/#review204140 -----------------------------------------------------------
Patch looks great! Reviews applied: [67384, 67385, 67386, 67387, 67388, 67389, 67390, 67391, 67392, 67393] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 30, 2018, 6:40 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67393/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 6:40 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-5815 > https://issues.apache.org/jira/browse/MESOS-5815 > > > Repository: mesos > > > Description > ------- > > With the IOCP backened implemented, io_tests.cpp is now ported to > Windows. Since the tests require async pipe IO, the tests are only > run if Mesos was compiled with the IOCP backened. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/CMakeLists.txt > 8c1353b442d5fc7b2e796a4d87f5b41389d4e1c3 > 3rdparty/libprocess/src/tests/io_tests.cpp > de7272b3ef0f414f056509448856c6bbd86ef75c > > > Diff: https://reviews.apache.org/r/67393/diff/1/ > > > Testing > ------- > > The entire chain was tested with `make check` on Linux. The tests were run on > Windows as well with `-DENABLE_LIBEVENT` and `-DENABLE_LIBWINIO`. > > > Thanks, > > Akash Gupta > >
