----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204160 -----------------------------------------------------------
Patch looks great! Reviews applied: [67118, 67064, 67065, 67066] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 30, 2018, 8:30 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67066/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 8:30 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, > Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala. > > > Bugs: MESOS-8064 > https://issues.apache.org/jira/browse/MESOS-8064 > > > Repository: mesos > > > Description > ------- > > Modified the fetcher to use libarchive and added associated tests. > > > Diffs > ----- > > src/launcher/fetcher.cpp 4cff7273fdc9e3897074da4da7dad02483086c2d > src/tests/fetcher_tests.cpp 8c353f2a30a6dd6338c91dad7ff76ff28d1005e8 > > > Diff: https://reviews.apache.org/r/67066/diff/7/ > > > Testing > ------- > > I've built on Windows with CMake and have run all tests, which all pass. > I've also built on Linux with both the autotools build and cmake build and > have run all tests, which all pass. > > > Thanks, > > John Kordich > >
