----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67372/#review204204 -----------------------------------------------------------
Fix it, then Ship it! src/tests/sorter_tests.cpp Line 1017 (original), 1027 (patched) <https://reviews.apache.org/r/67372/#comment286599> s/DRFSorter/TypeParam/ src/tests/sorter_tests.cpp Line 1054 (original), 1064 (patched) <https://reviews.apache.org/r/67372/#comment286600> ditto src/tests/sorter_tests.cpp Line 1093 (original), 1103 (patched) <https://reviews.apache.org/r/67372/#comment286601> ditto src/tests/sorter_tests.cpp Line 1133 (original), 1143 (patched) <https://reviews.apache.org/r/67372/#comment286602> ditto src/tests/sorter_tests.cpp Line 1166 (original), 1176 (patched) <https://reviews.apache.org/r/67372/#comment286603> ditto src/tests/sorter_tests.cpp Line 1287 (original), 1297 (patched) <https://reviews.apache.org/r/67372/#comment286604> ditto src/tests/sorter_tests.cpp Line 1569 (original), 1579 (patched) <https://reviews.apache.org/r/67372/#comment286605> ditto src/tests/sorter_tests.cpp Lines 1622-1623 (original), 1620-1621 (patched) <https://reviews.apache.org/r/67372/#comment286606> Why are you changing the original setup and only benchmarking one value? src/tests/sorter_tests.cpp Line 1779 (original), 1767 (patched) <https://reviews.apache.org/r/67372/#comment286607> ditto - Meng Zhu On May 29, 2018, 6:02 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67372/ > ----------------------------------------------------------- > > (Updated May 29, 2018, 6:02 p.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu. > > > Bugs: MESOS-8936 > https://issues.apache.org/jira/browse/MESOS-8936 > > > Repository: mesos > > > Description > ------- > > Several of the sorter tests, including the benchmarks, were agnostic > to the sorter implementation. These have been updated to run for both > `DRFSorter` and `RandomSorter`. The remainder have been updated to > be called DRFSorter tests. > > > Diffs > ----- > > src/tests/sorter_tests.cpp da4e0f64a565af1d9458ff256ae0eafddd0a6b68 > > > Diff: https://reviews.apache.org/r/67372/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
