> On June 1, 2018, 12:26 a.m., Meng Zhu wrote: > >
Great review, thanks for catching all of these! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67371/#review204159 ----------------------------------------------------------- On May 30, 2018, 1 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67371/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 1 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu. > > > Bugs: MESOS-8936 > https://issues.apache.org/jira/browse/MESOS-8936 > > > Repository: mesos > > > Description > ------- > > This sorter returns a weighted random shuffling of its clients > upon each `sort()` request. > > This implementation is a copy of the `DRFSorter` with share > calculation logic (including the `dirty` bit) removed and an > adjusted `sort()` implementation. Work needs to be done to > reduce the amount of duplicated logic needed across sorter > implementations, but it is left unaddressed here. > > > Diffs > ----- > > src/Makefile.am b7184ceccef5f2e985d905c155156f95c7a7c7b4 > src/master/allocator/sorter/random/sorter.hpp PRE-CREATION > src/master/allocator/sorter/random/sorter.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/67371/diff/1/ > > > Testing > ------- > > Unit tests added in subsequent patch. > > > Thanks, > > Benjamin Mahler > >
