> On June 1, 2018, 8:53 p.m., Meng Zhu wrote: > > include/mesos/allocator/allocator.hpp > > Line 65 (original), 68 (patched) > > <https://reviews.apache.org/r/67374/diff/1/?file=2031739#file2031739line68> > > > > I think exporting quotaRole sorter could also be useful, add a TODO?
Yeah, although I think if we were to do this we probably would need the quota guarantee sorter to be configurable at framework level? - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67374/#review204201 ----------------------------------------------------------- On May 30, 2018, 1:11 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67374/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 1:11 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Meng Zhu. > > > Bugs: MESOS-8936 > https://issues.apache.org/jira/browse/MESOS-8936 > > > Repository: mesos > > > Description > ------- > > This deprecates `--user_sorter` in favor of `--role_sorter`. > > This patch also modifies the `--allocator` default to exclude "DRF" > from the value, while still ensuring the previous default works. > > For now, both sorter flags must be set to `drf` or `random`. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > e5a5355646c834280008867e89eb258eaefc2f1d > src/master/allocator/allocator.cpp e3dd7376b5f05e72d9b9aa895ed3aebc461e4372 > src/master/constants.hpp b31e5f027b44d371050cea9a4662a4b54127812f > src/master/flags.hpp 4715f2bf4eb62808265f3062f93e370faa53e63d > src/master/flags.cpp 4ad13752719daf2cfad1f578edffc1f16a101760 > src/master/main.cpp 3eb1f89cb877fdd84434954ed80e753b1f859338 > > > Diff: https://reviews.apache.org/r/67374/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
