----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67414/#review204313 -----------------------------------------------------------
3rdparty/libprocess/include/process/http.hpp Line 701 (original), 701-702 (patched) <https://reviews.apache.org/r/67414/#comment286735> Why not using `process::http::Status::string()` https://github.com/apache/mesos/blob/2198b961d24b788564d36490cf52f78d7ec07655/3rdparty/libprocess/src/http.cpp#L176-L180 instead? Maybe then you can even put a single line into `Response` c-tor instead of modifying individual classes. - Alexander Rukletsov On June 1, 2018, 3:14 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67414/ > ----------------------------------------------------------- > > (Updated June 1, 2018, 3:14 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > By default on error libprocess would only return a response > with the correct status code and no response body. > > However, most browsers do not visually indicate the response > status code, making it hard for the user to figure out what > exactly the problem was. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 055447e13117c0a3ba79d0fc326ece657e8f064f > > > Diff: https://reviews.apache.org/r/67414/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
