----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67454/#review204341 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On June 5, 2018, 12:09 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67454/ > ----------------------------------------------------------- > > (Updated June 5, 2018, 12:09 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao, > Eric Mumau, Jie Yu, Joseph Wu, Li Li, and Radhika Jandhyala. > > > Bugs: MESOS-8977 > https://issues.apache.org/jira/browse/MESOS-8977 > > > Repository: mesos > > > Description > ------- > > Replaced most of the ArchiverTest.ExtractZipFileWithLongDestinationDir > test such that it constructs a long path similar to how it is done in > filesystem_tests.cpp. This resolves a failure in the jenkins BuildBot > job that runs all of the tests inside a docker container, which uses a > filesystem called AUFS, which has an individual file name limit of 242 > characters. > > > Diffs > ----- > > 3rdparty/stout/tests/archiver_tests.cpp > fc8db56897ba7e5881a8af27da11c1d21c835b94 > > > Diff: https://reviews.apache.org/r/67454/diff/1/ > > > Testing > ------- > > I ran the cmake build on both Linux and Windows and verified the tests pass. > I was not able to run the tests inside a docker container, but considering > the changes made, I would be very surprised if it failed in the same way > because we are no longer creating a filename with greater than 242 characters. > > > Thanks, > > John Kordich > >
