----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67456/#review204463 -----------------------------------------------------------
Ship it! Ship It! - Andrew Schwartzmeyer On June 5, 2018, 1:38 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67456/ > ----------------------------------------------------------- > > (Updated June 5, 2018, 1:38 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-7342 > https://issues.apache.org/jira/browse/MESOS-7342 > > > Repository: mesos > > > Description > ------- > > One of the docker tests revealed that the docker executor code could > leak some of the docker processes if it gets killed. To avoid this, we > run the docker executor and all processes launched by it in a job > object, so that `os::killtree` will properly kill the process tree. > > > Diffs > ----- > > src/docker/docker.cpp 1332d4b8cc8dc48abd5f07689b18a5b39ca946cf > src/docker/executor.cpp 572594a110aa4b51a698b176287b6ff823b2dd07 > src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be > > > Diff: https://reviews.apache.org/r/67456/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
