----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67496/#review204477 -----------------------------------------------------------
Patch looks great! Reviews applied: [67496] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 7, 2018, 4:19 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67496/ > ----------------------------------------------------------- > > (Updated June 7, 2018, 4:19 p.m.) > > > Review request for mesos, James Peach and Radhika Jandhyala. > > > Repository: mesos > > > Description > ------- > > The difference between `os::unsetenv` and `os::eraseenv` is important, > but subtle. Now the reason for the existence of `os::eraseenv` is > documented in comments. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/os.hpp > f898f07515bcc663fea1eef52497feb518d4ca53 > 3rdparty/stout/include/stout/windows/os.hpp > 3a728f8cb699c1a4a0bbbf1ecb44f9d33b60e4e3 > 3rdparty/stout/tests/os/env_tests.cpp > b5b124dc6316e661af6dd90335ade5283c26d9f2 > > > Diff: https://reviews.apache.org/r/67496/diff/1/ > > > Testing > ------- > > stout-tests on Windows > > > Thanks, > > Andrew Schwartzmeyer > >
