----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67457/#review204507 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/docker_containerizer_tests.cpp Line 300 (original), 339 (patched) <https://reviews.apache.org/r/67457/#comment287027> What changed here to need another argument? src/tests/containerizer/docker_containerizer_tests.cpp Lines 5107-5120 (patched) <https://reviews.apache.org/r/67457/#comment287028> I am so sorry. - Andrew Schwartzmeyer On June 5, 2018, 1:40 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67457/ > ----------------------------------------------------------- > > (Updated June 5, 2018, 1:40 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Bugs: MESOS-7342 > https://issues.apache.org/jira/browse/MESOS-7342 > > > Repository: mesos > > > Description > ------- > > With some Docker bug fixes and the IOCP backend, the remaining docker > have been ported. The only remaining Docker tests that aren't ported > are either due to limitations on Windows Containers or unimplemented > features in Mesos (Persistent volume and hooks). > > > Diffs > ----- > > src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132 > src/tests/containerizer/docker_containerizer_tests.cpp > 194308bf9d09a3562e683c49e0da4c9a6463d66e > > > Diff: https://reviews.apache.org/r/67457/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
