----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67522/ -----------------------------------------------------------
Review request for mesos and Jan Schlicht. Repository: mesos Description ------- Since we are using C++11 and the declared constants are either POD or `constexpr` types, we can define them in the header as `constexpr`. This also removes the need to declare the constants as `extern` which should using them easier (e.g., simpler linkage requirements). Diffs ----- 3rdparty/libprocess/Makefile.am d434001fbc49d337b6e29f6ac8c9c7475922a819 3rdparty/libprocess/include/process/timeseries.hpp 64b10a8d551ba33e252aa33987e3d5da8d56a1d6 3rdparty/libprocess/src/CMakeLists.txt cf443dffd0663ecf02b7efd6f7094175b94aae19 3rdparty/libprocess/src/timeseries.cpp 528adef504ea82eb4bec309d8d17e6347c652a29 Diff: https://reviews.apache.org/r/67522/diff/1/ Testing ------- `make check` Thanks, Benjamin Bannier