----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67394/#review204549 -----------------------------------------------------------
src/slave/containerizer/mesos/launcher.hpp Lines 73 (patched) <https://reviews.apache.org/r/67394/#comment287111> `= {}` src/slave/containerizer/mesos/launcher.hpp Lines 110 (patched) <https://reviews.apache.org/r/67394/#comment287112> `= {}` src/slave/containerizer/mesos/linux_launcher.hpp Lines 60 (patched) <https://reviews.apache.org/r/67394/#comment287107> `= {}` src/slave/containerizer/mesos/linux_launcher.cpp Lines 82 (patched) <https://reviews.apache.org/r/67394/#comment287108> Ditto. src/tests/containerizer/launcher.hpp Lines 59-72 (original), 59-82 (patched) <https://reviews.apache.org/r/67394/#comment287110> I'm not sure I follow; why do we need this entire change instead of just `s/10/9`, adding `whiteListFds`, and changing to `containerIO`? src/tests/containerizer/mesos_containerizer_tests.cpp Lines 1338-1344 (original), 1338-1343 (patched) <https://reviews.apache.org/r/67394/#comment287109> Does `containerIO` default construct with stdin/out/err set to valid file descriptors? - Andrew Schwartzmeyer On May 31, 2018, 3:50 p.m., Radhika Jandhyala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67394/ > ----------------------------------------------------------- > > (Updated May 31, 2018, 3:50 p.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jie Yu, and Li > Li. > > > Repository: mesos > > > Description > ------- > > White list fds that child processes can inherit in mesos containerizer. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > eac1d16f2388385fec04ff8f013ce0ebf4e97f0f > src/slave/containerizer/mesos/launcher.hpp > f69d934d2e1a129e10df8c7f5c78723e832adc7d > src/slave/containerizer/mesos/launcher.cpp > 2fe47d368cb82a46328e1f636baa836272db244c > src/slave/containerizer/mesos/linux_launcher.hpp > 0ea9b875ae46cadea483bc8dd8bf4907fd324dc9 > src/slave/containerizer/mesos/linux_launcher.cpp > 80e444501e429c1e1ae354abcd51f86430316ada > src/tests/containerizer/launcher.hpp > a8e436f164b67d937ebcff35e084d3ca755c003c > src/tests/containerizer/launcher.cpp > a92d9890f0931425d69ef8ce0896d081b8722079 > src/tests/containerizer/mesos_containerizer_tests.cpp > 01f2b38cfa67b144298c361e92170322864ac201 > > > Diff: https://reviews.apache.org/r/67394/diff/1/ > > > Testing > ------- > > All mesos tests on windows > > > Thanks, > > Radhika Jandhyala > >
