----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67535/#review204593 -----------------------------------------------------------
3rdparty/stout/CMakeLists.txt Line 24 (original) <https://reviews.apache.org/r/67535/#comment287173> This does not look correct to me. The header `stout/svn.hpp` explicitly includes `apr_pools.h` so stout _does_ have a dependency on `apr`. We could make this dependency conditional like the dependency on svn here (might also help to add a comment documenting that `apr` is needed for interaction with `svn`. - Benjamin Bannier On June 11, 2018, 11:57 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67535/ > ----------------------------------------------------------- > > (Updated June 11, 2018, 11:57 p.m.) > > > Review request for mesos, Benjamin Bannier and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Because SVN now includes APR as an interface dependency, the explicit > linkage to APR in the stout interface is not necessary. Instead, APR > is included transitively when SVN is included. > > This fixes the unexpected behavior on Windows were APR is built and > linked against despite not being used at all since SVN isn't used. > > > Diffs > ----- > > 3rdparty/stout/CMakeLists.txt 9cbb6f2a13fe9201fdebb9e9994d7725e53af083 > > > Diff: https://reviews.apache.org/r/67535/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
