----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67412/#review204688 -----------------------------------------------------------
configure.ac Lines 2278 (patched) <https://reviews.apache.org/r/67412/#comment287300> Instead of this long complicated line, can we just set PYTHON_VERSION directrly from: ``` PYTHON_VERSION=`$PYTHON -c "import sys; sys.stdout.write(sys.version[[:3]])"` ``` - Kevin Klues On June 1, 2018, 3:14 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67412/ > ----------------------------------------------------------- > > (Updated June 1, 2018, 3:14 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, > and Kevin Klues. > > > Bugs: MESOS-8955 > https://issues.apache.org/jira/browse/MESOS-8955 > > > Repository: mesos > > > Description > ------- > > We set `PYTHON` and `PYTHON_VERSION` when configuring the build. > We now cover all possible cases (both variables set, only one, none). > This ensures that both variables are set after being checked. > > > Diffs > ----- > > configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 > > > Diff: https://reviews.apache.org/r/67412/diff/2/ > > > Testing > ------- > > I added two lines after the new code: > ``` > AC_MSG_NOTICE([$PYTHON]) > AC_MSG_NOTICE([$PYTHON_VERSION]) > ``` > > Then, when using `configure`, I've checked the output. > ``` > $ ../configure > ... > configure: /usr/bin/python > configure: 2.7 > $ PYTHON_VERSION=4 ../configure > ... > configure: python4 > configure: 4 > $ PYTHON=yolo ../configure > ... > configure: yolo > configure: > ``` > > > Thanks, > > Armand Grillet > >
