----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/#review204712 -----------------------------------------------------------
I wonder if this is really more explicit? Right now it seems very likely to me that e.g., `Slave::info` would refer to a `SlaveInfo`; calling it `Slave::slaveInfo` doesn't seem to add much. There also seems to be no need to disambiguate here as the datstructures touched here do not contain more that a single `*Info` value. Note that we use a similar pattern in e.g., `master.hpp` and `hierarchical.hpp`. - Benjamin Bannier On June 13, 2018, 7:14 p.m., bin zheng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67567/ > ----------------------------------------------------------- > > (Updated June 13, 2018, 7:14 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Gilbert Song. > > > Bugs: MESOS-8680 > https://issues.apache.org/jira/browse/MESOS-8680 > > > Repository: mesos > > > Description > ------- > > Changed the variable name of the Class "Slave", "Executor" and "Framework" in > Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or > "frameworkInfo". also change others in related files: http.cpp and slave.cpp. > > > Diffs > ----- > > src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 > src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 > src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a > > > Diff: https://reviews.apache.org/r/67567/diff/1/ > > > Testing > ------- > > > Thanks, > > bin zheng > >
