> On April 20, 2018, 1:39 p.m., Benjamin Bannier wrote: > > LGTM, but I wonder whether it would make sense to keep the assertions and > > reject outdated resources more generally based on e.g., resource versions.
Hmm good point. I thought about it a bit. I changed these assertions for accepted pending operations, which we have already verified the resource versions. The current update logic is the following. When SLRP receives changes in the set of known profiles: 1. Query the disk profile adaptor to update the ProfileInfo for each profile. 2. Wait for all related pending operations to finish. Some of them may want to use outdated profiles. 3. Reconcile the storage pool. If we want to keep the assertion, the logic would look like the following. When SLRP receives changes in the set of known profiles: 1. Wait for all related operations to finish. They are allowed to use the outdated profiles, so new volumes with those profiles might be created successfully. 2. Query the disk profile adaptor to update the ProfileInfo for each profile. 3. Reconcile the storage pool. Personally I prefer the former, since it doesn't make sense to create new volumes for old profiles. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/#review201631 ----------------------------------------------------------- On June 14, 2018, 12:07 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65976/ > ----------------------------------------------------------- > > (Updated June 14, 2018, 12:07 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-8825 > https://issues.apache.org/jira/browse/MESOS-8825 > > > Repository: mesos > > > Description > ------- > > Allowed profiles to be missing from `DiskProfileAdaptor`. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > b90a4b81838fec410a97a10ce44a811bb81c87eb > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 > > > Diff: https://reviews.apache.org/r/65976/diff/4/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
