----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67525/#review204779 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On June 13, 2018, 9:23 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67525/ > ----------------------------------------------------------- > > (Updated June 13, 2018, 9:23 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > The static variable was initialized using a dynamic memory > allocation. This is against our coding style, and makes it > as easy as writing > > static process::http::NotFound DEFAULT_RESPONSE; > > for a user to introduce a potential segfault into his code. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > 055447e13117c0a3ba79d0fc326ece657e8f064f > 3rdparty/libprocess/src/decoder.hpp > a0784358d63279022473fdf82a72b7ecc9056658 > 3rdparty/libprocess/src/http.cpp 9fd5ea02ee57b4ad2d30c4b9ac4cbd299942d501 > 3rdparty/libprocess/src/tests/http_tests.cpp > ca1ea116866b5ccd3d42e93dd5bd7fed2234df0d > > > Diff: https://reviews.apache.org/r/67525/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benno Evers > >
