----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67585/#review204804 -----------------------------------------------------------
Fix it, then Ship it! LGTM src/slave/containerizer/docker.cpp Lines 1383-1385 (patched) <https://reviews.apache.org/r/67585/#comment287534> Please follow this format: ``` if (containers_[containerId]->state == Container::DESTROYING) { return Failure( "Container is being destroyed during launching excutor container"); } ``` src/slave/containerizer/docker.cpp Lines 1386 (patched) <https://reviews.apache.org/r/67585/#comment287533> one newline below src/slave/containerizer/docker.cpp Lines 1478-1479 (patched) <https://reviews.apache.org/r/67585/#comment287535> ditto - Gilbert Song On June 13, 2018, 5:34 p.m., CHEN RUNCONG wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67585/ > ----------------------------------------------------------- > > (Updated June 13, 2018, 5:34 p.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-6092 > https://issues.apache.org/jira/browse/MESOS-6092 > > > Repository: mesos > > > Description > ------- > > Fixed the issue:if the container is destroyed in the mean time, then we will > potentially segfault here. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be > > > Diff: https://reviews.apache.org/r/67585/diff/2/ > > > Testing > ------- > > > Thanks, > > CHEN RUNCONG > >
