----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67604/#review204811 -----------------------------------------------------------
PASS: Mesos patch 67604 was successfully built and tested. Reviews applied: `['67603', '67604']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67604 - Mesos Reviewbot Windows On June 14, 2018, 10:20 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67604/ > ----------------------------------------------------------- > > (Updated June 14, 2018, 10:20 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > While this is not required for the autotools build where manual > intervention is needed to make the output of `AC_CONFIG_FILES` > executable, cmake will copy existing permissions when executing > `configure_file`. Making the input files explicitly executable > simplifies the needed steps in the cmake build and also serves as > documentation. > > > Diffs > ----- > > cmake/MesosConfigure.cmake 0954a9cd31fa290ff9099be4b06d69d96b701f1e > > > Diff: https://reviews.apache.org/r/67604/diff/1/ > > > Testing > ------- > > NOTE: > > **Reviewboard seems to have issues tracking the permission changes in this > patch. > Please apply the patch file below instead of the patch related directly to > this rr.** > > (done shouting) > > > # Testing done > > * made sure that all shell scripts created as part of `cmake ..` are > executable > * `make distcheck` for good measure, but likely unable to detect issues here. > > > File Attachments > ---------------- > > PLEASE APPLY THIS PATCH MANUALLY INSTEAD > > https://reviews.apache.org/media/uploaded/files/2018/06/14/2503e381-af7c-4de4-ac67-d259102bf5cf__0001-Made-configured-shell-script-inputs-executable.patch > > > Thanks, > > Benjamin Bannier > >
