----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67355/#review204834 -----------------------------------------------------------
Fix it, then Ship it! I'll fix the outstanding issues and commit shortly. src/executor/executor.cpp Line 171 (original), 172-173 (patched) <https://reviews.apache.org/r/67355/#comment287577> Add a TODO MESOS-9001. - Alexander Rukletsov On May 29, 2018, 2:20 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67355/ > ----------------------------------------------------------- > > (Updated May 29, 2018, 2:20 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, haosdent > huang, Ilya Pronin, and James Peach. > > > Bugs: MESOS-3475 > https://issues.apache.org/jira/browse/MESOS-3475 > > > Repository: mesos > > > Description > ------- > > This patch adds overloaded constructor for `v1::executor::Mesos` class > that accepts `environment` parameter that is passed over to > `MesosProcess` constructor. This change is needed to get rid of > `os::getenv()` calls, so that v1 Executor can be used in tests that > require thread safety. > > > Diffs > ----- > > include/mesos/v1/executor.hpp ca48f29483f3f5caeb070f33d009ab89c9f4829b > src/executor/executor.cpp 5e95f999535a81bf6873144a83d520897b3cdc8a > src/tests/mesos.hpp 8f529fad7041cb375dc6b0e07273a8412d5519b4 > > > Diff: https://reviews.apache.org/r/67355/diff/4/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
