> On June 18, 2018, 3:38 p.m., Benjamin Bannier wrote: > > src/Makefile.am > > Lines 2517 (patched) > > <https://reviews.apache.org/r/65640/diff/5/?file=2040461#file2040461line2517> > > > > This looks unrelated, and AFAICT not needed. > > > > Let's remove this from the patch. > > Chun-Hung Hsiao wrote: > This is required for the test to use `FUTURE_DISPATCH` on > `UriDiskProfileAdaptorProcess::_poll` without a link error.
The symbols from that file are already in `liburi_disk_profile_adaptor` and we should not add them directly here (if we'd link to the library in the future we'd have ODR violations). Instead we should link `libmesos` or `mesos_tests` with that library; the cmake build links `libmesos` with `liburi_disk_profile_adaptor`. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65640/#review204923 ----------------------------------------------------------- On June 14, 2018, 2:20 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65640/ > ----------------------------------------------------------- > > (Updated June 14, 2018, 2:20 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-8567 > https://issues.apache.org/jira/browse/MESOS-8567 > > > Repository: mesos > > > Description > ------- > > There was a race between `Clock::advance()` in the `FetchFromHTTP` test > and `delay()` in `UriDiskProfileAdaptorProcess::_poll`. This patch > avoids the race by enforcing an order between the dispatch of the > `__poll` function (previously `_poll`) and the clock manipulation > in the test. > > > Diffs > ----- > > src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 > src/resource_provider/storage/uri_disk_profile_adaptor.hpp > 0484933b42d0bd66c689b06cb48f492eef7bc606 > src/resource_provider/storage/uri_disk_profile_adaptor.cpp > 614590ef7d1c0cc1df99b8e57c7fbd496793b5a7 > src/tests/disk_profile_adaptor_tests.cpp > 4485f1635f484ce6e1c7c532eedb277f5eee118b > > > Diff: https://reviews.apache.org/r/65640/diff/5/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
