----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/#review204986 -----------------------------------------------------------
Fix it, then Ship it! LGTM! src/tests/containerizer/provisioner_docker_tests.cpp Lines 244 (patched) <https://reviews.apache.org/r/67597/#comment287832> Could you add "This is a regression test for MESOS-8871." src/tests/containerizer/provisioner_docker_tests.cpp Lines 246 (patched) <https://reviews.apache.org/r/67597/#comment287833> I would name it as `MetadataManagerRecoveryWithEmptyImagesFile` src/tests/containerizer/provisioner_docker_tests.cpp Lines 252 (patched) <https://reviews.apache.org/r/67597/#comment287835> 1. const string ... 2. s/empty_images/storedImagesPath/g (usually we don't use `snake` style for variable names. src/tests/containerizer/provisioner_docker_tests.cpp Lines 254 (patched) <https://reviews.apache.org/r/67597/#comment287837> do we need this mkdir? src/tests/containerizer/provisioner_docker_tests.cpp Lines 260 (patched) <https://reviews.apache.org/r/67597/#comment287836> newline above. - Gilbert Song On June 15, 2018, 10:44 a.m., bin zheng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67597/ > ----------------------------------------------------------- > > (Updated June 15, 2018, 10:44 a.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-8871 > https://issues.apache.org/jira/browse/MESOS-8871 > > > Repository: mesos > > > Description > ------- > > Fixed an issue where agent may fail to recover. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp > 98c8fc769f2525c66539f08e2aa82506912e8a59 > src/tests/containerizer/provisioner_docker_tests.cpp > 71247c308b205de3d20a41ceb06eed6aa70fb25d > > > Diff: https://reviews.apache.org/r/67597/diff/2/ > > > Testing > ------- > > > Thanks, > > bin zheng > >
