----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67656/#review205039 -----------------------------------------------------------
Patch looks great! Reviews applied: [67656] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 19, 2018, 9:18 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67656/ > ----------------------------------------------------------- > > (Updated June 19, 2018, 9:18 p.m.) > > > Review request for mesos, Benjamin Bannier and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Building `stout-tests` without having first built the default targets > was broken for two reasons: it was lacking the dependency required to > build the bundled `libarchive`, and it was lacking the dependency > required to generate the test `protobuf` sources. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 5b922af6cd58dc03c44aacf88637e89f6e289702 > > > Diff: https://reviews.apache.org/r/67656/diff/1/ > > > Testing > ------- > > I have no clue if adding `BUILT_SOURCES` as a dependency of `tests` was > correct, but it worked. If there is a correct way to do this in Autotools, I > am all ears. > > Was able to build with bundled `libarchive` after configuring, cd'ing into > the stout directory, and building _just_ `make tests` without having built > anything else. > > > Thanks, > > Andrew Schwartzmeyer > >
