----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67669/#review205079 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp Line 921 (original) <https://reviews.apache.org/r/67669/#comment288036> While this might not be required by the allocator, generally an operation changing the resource quantity is not supported by the `Sorter` interface. We already rely on the invariant being checked here in above calls to `Sorter::update` which explicit disallow such updates. In order to support operations changing the quantity of the stripped resources we need to do additional work. - Benjamin Bannier On June 20, 2018, 7:34 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67669/ > ----------------------------------------------------------- > > (Updated June 20, 2018, 7:34 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng > Zhu. > > > Bugs: MESOS-8995 > https://issues.apache.org/jira/browse/MESOS-8995 > > > Repository: mesos > > > Description > ------- > > `HierarchicalAllocatorProcess::updateAllocation` checks that the given > resource conversions should not change the allocation quantities of the > specified framework. Although this is true for speculative operations, > this might not hold for arbitrary resource conversions in general. > > Since the allocator does not rely on this invariant, this patch relaxes > the invariant to make resource conversions more future-proof. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > b558228290e5ae6dbcc1b8a6e1fe69db9fd5874c > > > Diff: https://reviews.apache.org/r/67669/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
