----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67665/#review205081 -----------------------------------------------------------
Ship it! src/tests/storage_local_resource_provider_tests.cpp Lines 257-260 (patched) <https://reviews.apache.org/r/67665/#comment288038> Since we know that `Try::get` checks valid state or would abort otherwise, we might as well directly return the result of `strings::format(..).get()` above instead of adding this code. We often follow a similar pattern elsewhere in the test code, e.g., `Resources::parse(..).get()`. OTOH, what you do here is nicely explicit. - Benjamin Bannier On June 20, 2018, 7:33 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67665/ > ----------------------------------------------------------- > > (Updated June 20, 2018, 7:33 a.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan > Schlicht. > > > Bugs: MESOS-8995 > https://issues.apache.org/jira/browse/MESOS-8995 > > > Repository: mesos > > > Description > ------- > > This patch changes the `setupDiskProfileMapping` helper used in SLRP > tests to `createDiskProfileMapping`, which returns a JSON string with a > configurable profile name instead of writing the JSON into a fixed path. > This gives us more flexibility to test adding and removing profiles. In > addition, the `loadUriDiskProfileAdaptor` helper now accept arguments to > set up its poll URI and interval. > > The "block-default" profile is removed since it does not have value to > test block profiles. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 1afe8a8e0413ef225e952cd9cd6376e5d82774e5 > > > Diff: https://reviews.apache.org/r/67665/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
