----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/ -----------------------------------------------------------
(Updated June 20, 2018, 11:25 a.m.) Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang. Changes ------- Qian's comments. Summary (updated) ----------------- Added an hourly timer for `containerizer/docker/image_pull`. Bugs: MESOS-6451 https://issues.apache.org/jira/browse/MESOS-6451 Repository: mesos Description (updated) ------- Added an hourly timer for `containerizer/docker/image_pull`. Diffs (updated) ----- src/slave/containerizer/docker.hpp 1ed47c85f765da6fb91a2a243fcc5030e9686190 src/slave/containerizer/docker.cpp f83036aa5a212d1d88e6f5aa41023abc125f7116 Diff: https://reviews.apache.org/r/53105/diff/6/ Changes: https://reviews.apache.org/r/53105/diff/5-6/ Testing (updated) ------- Ran `mesos-execute` with a docker image and docker containerizer twice, observed the following metrics: ``` curl -s localhost:5051/metrics/snapshot | jq . "containerizer/docker/image_pull_ms": 6628.833024, "containerizer/docker/image_pull_ms/count": 2, "containerizer/docker/image_pull_ms/max": 8851.497216, "containerizer/docker/image_pull_ms/min": 6628.833024, "containerizer/docker/image_pull_ms/p50": 7740.16512, "containerizer/docker/image_pull_ms/p90": 8629.2307968, "containerizer/docker/image_pull_ms/p95": 8740.3640064, "containerizer/docker/image_pull_ms/p99": 8829.27057408, "containerizer/docker/image_pull_ms/p999": 8849.274551808, "containerizer/docker/image_pull_ms/p9999": 8851.2749495808, ``` Thanks, Zhitao Li