> On June 20, 2018, 2:35 p.m., Benjamin Bannier wrote: > > Would it make sense to add these log lines only for some higher log level > > (which one)? I am mostly worried about the amount of additional log output > > this could generate in huge clusters, we might e.g., log tens of thousands > > of offerIds per offer cycle.
My counter argument would be that we log offer IDs for every `ACCEPT` and `DECLINE` call, so the amount of log output added by this line is similar to those logs. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65875/#review205082 ----------------------------------------------------------- On June 20, 2018, 5:37 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65875/ > ----------------------------------------------------------- > > (Updated June 20, 2018, 5:37 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Gastón > Kleiman, and Greg Mann. > > > Repository: mesos > > > Description > ------- > > Printed offer IDs and inverse offer IDs when sending out offers and > inverse offers so it is easier to match them to their ACCEPT or DECLINE > calls and removals. > > > Diffs > ----- > > src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 > > > Diff: https://reviews.apache.org/r/65875/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
