-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67680/#review205135
-----------------------------------------------------------


Ship it!




Looks good module a minor comment. Feel free to drop if it's too much.

- Kapil Arya


On June 20, 2018, 7:55 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67680/
> -----------------------------------------------------------
> 
> (Updated June 20, 2018, 7:55 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Kapil Arya.
> 
> 
> Bugs: MESOS-9008
>     https://issues.apache.org/jira/browse/MESOS-9008
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The archiver utility may fail to extract hardlinks when the destination
> target is different than the current working directory.  This happens
> because hardlinks are generally expressed in relative terms within
> an archive, but the target should be changed to point to the extracted
> location during extraction.
> 
> This updates the archiver utility to handle links correctly and adds
> a regression test.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/archiver.hpp 
> f66da36de94f46c799cb1028b6e8c0ed26c9f3ae 
>   3rdparty/stout/tests/archiver_tests.cpp 
> eddda0872f02a4918cffc22ebc0da2c46b172fd9 
> 
> 
> Diff: https://reviews.apache.org/r/67680/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> The tarball was generated with the following:
> ```
> echo "I'm a link target" > target
> ln target hardlink
> ln -s target symlink
> tar -czf foo.tar.gz target hardlink symlink
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to