----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67615/#review205175 -----------------------------------------------------------
Patch looks great! Reviews applied: [67561, 67615] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 21, 2018, 4:56 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67615/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 4:56 a.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, Kapil Arya, and Till > Toenshoff. > > > Repository: mesos > > > Description > ------- > > Currently `createStrippedScalarQuantity()` strips resource meta-data > except revocable and turns dynamic reservation into static reservation. > However, no current code depends on this behavior and this leads to > boilerplate code around call sites and performance overhead. > > This patch further clears the above meta-data for simplicity > and performance. > > > Diffs > ----- > > include/mesos/resources.hpp bd6d6d61a8637ecb3ababaf7247b5fc49cc8b070 > include/mesos/v1/resources.hpp c065dd16e7723ef093a8e58841495e2bd47ce9d8 > src/common/resources.cpp b9f1c2ddbcd09ae1a1ab2caf9856d1fb9a589e89 > src/master/allocator/mesos/hierarchical.cpp > f631ce73d578a313dfdacf1ee97737dde90ae8f8 > src/tests/resources_tests.cpp 14104239da7dec2aa6d6e78777249c69bd019a6d > src/tests/sorter_tests.cpp 9cdffd778967bca3d0055be8a04fbb702432e59d > src/v1/resources.cpp 3d06fc64a19ab57d2af5fb465d3dc06ba79afcc5 > > > Diff: https://reviews.apache.org/r/67615/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
