----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/#review205196 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_tests.cpp Lines 2413 (patched) <https://reviews.apache.org/r/67601/#comment288128> Instead of to string.find(), I would prefer: ``` ASSERT_TRUE(value->is<JSON::Object>()); JSON::Object object = value->as<JSON::Object>(); EXPECT_SOME(object.find<JSON::String>("container_id")); ``` - Gilbert Song On June 15, 2018, 6:20 p.m., longfei niu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67601/ > ----------------------------------------------------------- > > (Updated June 15, 2018, 6:20 p.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-8816 > https://issues.apache.org/jira/browse/MESOS-8816 > > > Repository: mesos > > > Description > ------- > > Added field container_id in ResourceUsage to agent monitor endpoint. > > > Diffs > ----- > > src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 > src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed > > > Diff: https://reviews.apache.org/r/67601/diff/2/ > > > Testing > ------- > > add unit test to src/tests/slave_tests.cpp line 2414 to test whether > container_id field added sucessfully or not > > > Thanks, > > longfei niu > >
