----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67685/#review205214 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/stout/windows.hpp Lines 385-414 (patched) <https://reviews.apache.org/r/67685/#comment288159> I'm sorry, I lied. Can this go in `stout/windows/os.hpp` so it can go under `os::internal`? - Andrew Schwartzmeyer On June 21, 2018, 4:54 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67685/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 4:54 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8668 and MESOS-8671 > https://issues.apache.org/jira/browse/MESOS-8668 > https://issues.apache.org/jira/browse/MESOS-8671 > > > Repository: mesos > > > Description > ------- > > There are a couple of places where we need to convert a Windows > absolute time (epoch at 01/01/1601) to a UNIX absolute time (epoch at > 01/01/1970). So, a function has been added to handle it. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/stat.hpp > 7838bacabc4e2b9c92a5283f95543ee74b2d6505 > 3rdparty/stout/include/stout/windows.hpp > 075ad54ac694a11cb1e981a499e99c02cb734bc6 > > > Diff: https://reviews.apache.org/r/67685/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
