----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67384/#review205250 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On June 21, 2018, 4:34 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67384/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 4:34 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8668 > https://issues.apache.org/jira/browse/MESOS-8668 > > > Repository: mesos > > > Description > ------- > > Many Win32 functions that take in `HANDLE` also work on `SOCKET`, such > as `ReadFile` or `CreateIoCompletionPort`. IOCP on Windows uses the > `HANDLE` type uniformly, so we need to be able to convert socket > `int_fd` to `HANDLE`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/fd.hpp > 89a037af31ad68a275d2519afbe4f161b23efe91 > > > Diff: https://reviews.apache.org/r/67384/diff/2/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
