----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67385/#review205308 -----------------------------------------------------------
Ship it! Two more typos for Andy to fix before committing. 3rdparty/stout/include/stout/os/windows/fd.hpp Lines 203 (patched) <https://reviews.apache.org/r/67385/#comment288241> Nit: s/bookeeping/bookkeeping/ 3rdparty/stout/include/stout/os/windows/fd.hpp Lines 215 (patched) <https://reviews.apache.org/r/67385/#comment288240> Nit: s/assigns/assign/ - Joseph Wu On May 30, 2018, 11:58 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67385/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 11:58 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-5371 and MESOS-8668 > https://issues.apache.org/jira/browse/MESOS-5371 > https://issues.apache.org/jira/browse/MESOS-8668 > > > Repository: mesos > > > Description > ------- > > Mesos/Libprocess uses `os::nonblock()` in a way that assumes that it is > idempotent. Unfortunately, `CreateIoCompletionPort` is not idempotent, > so we need to wrap the function around our own code to make it so. We > need to keep it inside the `WindowsFD` class, because there isn't a way > to determine if a HANDLE is associated with an IOCP through the Win32 > API. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/dup.hpp > 5bda095e676b038cdaea04f7be23ba2a1aca9015 > 3rdparty/stout/include/stout/os/windows/fd.hpp > 89a037af31ad68a275d2519afbe4f161b23efe91 > > > Diff: https://reviews.apache.org/r/67385/diff/2/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
