----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67707/#review205323 -----------------------------------------------------------
support/check-cmake-missing-files.sh Lines 23 (patched) <https://reviews.apache.org/r/67707/#comment288247> Issue found in testing: this isn't compatible with Ubuntu's "sh" (which is actually dash). - Andrew Schwartzmeyer On June 22, 2018, 2:47 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67707/ > ----------------------------------------------------------- > > (Updated June 22, 2018, 2:47 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-8994 > https://issues.apache.org/jira/browse/MESOS-8994 > > > Repository: mesos > > > Description > ------- > > Added a support script to check for files missing in the cmake build. > > > Diffs > ----- > > support/check-cmake-missing-files.sh PRE-CREATION > > > Diff: https://reviews.apache.org/r/67707/diff/2/ > > > Testing > ------- > > Ran the added script and verified that the files where indeed missing from > the cmake build. > > > Thanks, > > Benjamin Bannier > >
