> On June 7, 2018, 11:07 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/tests/os_tests.cpp > > Lines 83-90 (original), 83-92 (patched) > > <https://reviews.apache.org/r/67494/diff/1/?file=2036343#file2036343line83> > > > > We could enable this test by using `GetEnvironmentStrings` manually in > > place of `os::raw::environment()`, and writing a second (but very similar) > > loop that deals with the wstring to string conversions.
I did look into that. The authors were against that: // itt is ungainly to implement the `char**` return using the Win32 APIs; // since `GetEnvironmentStrings` returns a completely different type, // we'd have to allocate a char** environment statically, or manage // allocation semantics of the `char**` differently across Unix and // Windows. // If you think it is needed, I can use this https://stackoverflow.com/questions/6321756/environment-variables-are-in-a-char-how-to-get-it-to-a-stdstring?utm_medium=organic&utm_source=google_rich_qa&utm_campaign=google_rich_qa > On June 7, 2018, 11:07 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/tests/os_tests.cpp > > Line 805 (original), 816-818 (patched) > > <https://reviews.apache.org/r/67494/diff/1/?file=2036343#file2036343line816> > > > > If this is a `TODO`, we should open and reference an accompanying issue. I don't see a JIRA issue tracking chown on Windows. So will drop - Radhika ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67494/#review204470 ----------------------------------------------------------- On June 7, 2018, 9:41 p.m., Radhika Jandhyala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67494/ > ----------------------------------------------------------- > > (Updated June 7, 2018, 9:41 p.m.) > > > Review request for Andrew Schwartzmeyer. > > > Bugs: MESOS-5813 > https://issues.apache.org/jira/browse/MESOS-5813 > > > Repository: mesos > > > Description > ------- > > Add notes against disabled tests and enbale RemoveWithContinueOnError. > > > Diffs > ----- > > 3rdparty/stout/tests/os/filesystem_tests.cpp > b17ab9aaa94ae14b6707a9ac7a54b9db38615f2a > 3rdparty/stout/tests/os/rmdir_tests.cpp > 518afc0ddedc4c53d01ac08a36234964f088420d > 3rdparty/stout/tests/os/strerror_tests.cpp > 6a69d52a5b9ae93f3393ab17a3282ecb30ad90b0 > 3rdparty/stout/tests/os_tests.cpp 419879a47eb14813b8c6cac8f4a3a3bb0b9e2bed > 3rdparty/stout/tests/proc_tests.cpp > cc698b46319f418d4f609379e772bc8553346b2c > > > Diff: https://reviews.apache.org/r/67494/diff/1/ > > > Testing > ------- > > Added notes against tests that are disabled in Windows. We can enable some of > these tests in the future if we do enable the required functionality on > Windows. > > > Thanks, > > Radhika Jandhyala > >
