----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67725/#review205335 -----------------------------------------------------------
Patch looks great! Reviews applied: [67723, 67724, 67725] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 25, 2018, 11:07 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67725/ > ----------------------------------------------------------- > > (Updated June 25, 2018, 11:07 a.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > In this patch we store the principal given by `CreateVolume` or > `CreateDisk` operations inside the resources created by the operation. > > This allows us to authorize `DestroyVolume` or `DestroyDisk` > operations against the principal which triggered the resource's > creation at some later point. > > > Diffs > ----- > > include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3 > include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1 > src/resource_provider/storage/provider.cpp > b90a4b81838fec410a97a10ce44a811bb81c87eb > src/tests/storage_local_resource_provider_tests.cpp > 1afe8a8e0413ef225e952cd9cd6376e5d82774e5 > > > Diff: https://reviews.apache.org/r/67725/diff/1/ > > > Testing > ------- > > `sudo make check` > > > Thanks, > > Benjamin Bannier > >
