----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67728/#review205339 -----------------------------------------------------------
Ship it! Ship It! - Qian Zhang On June 26, 2018, 3 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67728/ > ----------------------------------------------------------- > > (Updated June 26, 2018, 3 a.m.) > > > Review request for mesos, Qian Zhang and Sagar Patwardhan. > > > Bugs: MESOS-9025 > https://issues.apache.org/jira/browse/MESOS-9025 > > > Repository: mesos > > > Description > ------- > > The bug was introduced in https://reviews.apache.org/r/65987/ when we > want to allow nested container to have a separate network namespace than > its parent (MESOS-8534). > > The original code misses a `continue` statement after recovering regular > containers. > > I am surprised that the unit tests didn't catch the bug. We'll add a new > unit test for catching the regression. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > b6ad4fcf9f1596c07ddeb9bbb134f4619d189671 > > > Diff: https://reviews.apache.org/r/67728/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
