----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67590/#review205531 -----------------------------------------------------------
PASS: Mesos patch 67590 was successfully built and tested. Reviews applied: `['67590']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67590 - Mesos Reviewbot Windows On June 28, 2018, 7:34 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67590/ > ----------------------------------------------------------- > > (Updated June 28, 2018, 7:34 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8989 > https://issues.apache.org/jira/browse/MESOS-8989 > > > Repository: mesos > > > Description > ------- > > See summary. > > Also removed the current range benchmark which could produce > misleading results for subtraction (See MESOS-8989). > > > Diffs > ----- > > src/tests/resources_tests.cpp 0095b945ebfd9be52162547f3999826c8cc33f87 > > > Diff: https://reviews.apache.org/r/67590/diff/2/ > > > Testing > ------- > > Build with `-O2` optimization, ran on a multicore machine with peak frequency > at 2.2GHz: > > Took 23.31231ms to perform 1000 'a += b' operations on ports:[1-6, 11-16, > 21-26... and ports:[3-8, 13-18, 23-28... with size 100 > Took 85.494021ms to perform 1000 'a -= b' operations on ports:[1-6, 11-16, > 21-26... and ports:[3-8, 13-18, 23-28... with size 100 > Took 45.536174ms to perform 1000 'a + b' operations on ports:[1-6, 11-16, > 21-26... and ports:[3-8, 13-18, 23-28... with size 100 > Took 108.754885ms to perform 1000 'a - b' operations on ports:[1-6, 11-16, > 21-26... and ports:[3-8, 13-18, 23-28... with size 100 > > Took 309.716888ms to perform 1000 'a += b' operations on ports:[1-6, 11-16, > 21-26... and ports:[3-8, 13-18, 23-28... with size 1000 > Took 917.667222ms to perform 1000 'a -= b' operations on ports:[1-6, 11-16, > 21-26... and ports:[3-8, 13-18, 23-28... with size 1000 > Took 502.702844ms to perform 1000 'a + b' operations on ports:[1-6, 11-16, > 21-26... and ports:[3-8, 13-18, 23-28... with size 1000 > Took 1.178407509secs to perform 1000 'a - b' operations on ports:[1-6, 11-16, > 21-26... and ports:[3-8, 13-18, 23-28... with size 1000 > > Took 3.144658342secs to perform 1000 'a += b' operations on ports:[1-6, > 11-16, 21-26... and ports:[3-8, 13-18, 23-28... with size 10000 > Took 9.086052071secs to perform 1000 'a -= b' operations on ports:[1-6, > 11-16, 21-26... and ports:[3-8, 13-18, 23-28... with size 10000 > Took 4.518318425secs to perform 1000 'a + b' operations on ports:[1-6, 11-16, > 21-26... and ports:[3-8, 13-18, 23-28... with size 10000 > Took 10.604580315secs to perform 1000 'a - b' operations on ports:[1-6, > 11-16, 21-26... and ports:[3-8, 13-18, 23-28... with size 10000 > > > Thanks, > > Meng Zhu > >
