----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67444/#review205541 -----------------------------------------------------------
Patch looks great! Reviews applied: [67773, 67444] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On June 28, 2018, 8:55 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67444/ > ----------------------------------------------------------- > > (Updated June 28, 2018, 8:55 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8802 > https://issues.apache.org/jira/browse/MESOS-8802 > > > Repository: mesos > > > Description > ------- > > The allocator needs to keep track of role consumed quota > to maintain quota headroom. Currently this info is > constructed on the fly prior to each allocation cycle. > > This patch lets the allocator buildup and persist this info > across allocation cycles to improve performance and reduce > code complexity. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 > src/master/allocator/mesos/hierarchical.cpp > cbdfb2ba9c25755ac631557e0e7dbd721f861a4d > > > Diff: https://reviews.apache.org/r/67444/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
