----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67664/#review205568 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp Lines 8047-8048 (patched) <https://reviews.apache.org/r/67664/#comment288451> Not yours, but let's remove this comment, as it's just stating what is done in the code below. - Jan Schlicht On June 21, 2018, 6:29 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67664/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 6:29 a.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan > Schlicht. > > > Bugs: MESOS-9010 > https://issues.apache.org/jira/browse/MESOS-9010 > > > Repository: mesos > > > Description > ------- > > Since a resource provider and its operation status update manager run in > different actors, the `UPDATE_OPERATION_STATUS` call of a completed > operation may race with an `UPDATE_STATE` call. > > To deal with this race, the agent should update the latest statuses of > all completed operations received in the `UPDATE_STATE` call to avoid > erroneously applying those operations when receiving > `UPDATE_OPERATION_STATUS`es. > > > Diffs > ----- > > src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 > src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a > src/tests/slave_tests.cpp b46fb8efc524852f62428040ff958bd44e9efe9f > > > Diff: https://reviews.apache.org/r/67664/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
